Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Parse logo from frontmatter #5399

Merged
merged 7 commits into from
Dec 14, 2024
Merged

feat(cli): Parse logo from frontmatter #5399

merged 7 commits into from
Dec 14, 2024

Conversation

sbelkadi
Copy link
Contributor

Description

Page logo is now parsed from the frontmatter of a specific page, if it's present.

Changes Made

  • Logo is parsed from the frontmatter, and the image is captured/uploaded if local
  • Logo is referenced with a fileId in the markdown that's returned

Testing

  • Unit tests added/updated
  • Manual testing completed

@sbelkadi sbelkadi requested a review from dsinghvi December 12, 2024 16:12
Copy link

github-actions bot commented Dec 12, 2024

@sbelkadi sbelkadi marked this pull request as ready for review December 12, 2024 16:23
@sbelkadi sbelkadi changed the title (feat)cli: Parse logo from frontmatter feat(cli): Parse logo from frontmatter Dec 12, 2024
@dsinghvi dsinghvi merged commit a66123f into main Dec 14, 2024
52 of 53 checks passed
@dsinghvi dsinghvi deleted the sbelkadi/FER-3743 branch December 14, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants